The only issue I've run into is that the IonicPage metadata is set in the ionic-angular module and would need a concurrent update to not throw an error (also where the documentation update would be it seems). I've tried to follow the main Ionic's contributor guidelines for ease and to also keep the changes low. I wasn't sure if I'd be able to accomplish this or if sinedied would have time, apologies for any inconvenience). If it is, it'd be nice to see that reflected as an absolute somewhere in the docs (unless I'm blind which I very well might be).Īlright so I have made a branch in my forked repository including the changes necessary to add this config option to IonicPage (if already has a PR in the works please feel free to use that instead as they have more experience here. I've never seen any indication from the team that this is something other than preference. Really just adding that config option as noted would be great for this and save those of us who used Angular naming from having to go through and rename up to 40 or so files and any references while losing our organization. ![]() This may be the majority but certainly not -all- and it isn't even a corner case of us either, given how many people using the *.page.ts naming seen around other issues. This still doesn't seem to be an intended result, seeing as it's been noted that they may consider switch naming conventions ( X) or at the very minimum don't discourage following Angular's ( X). ![]() I've been following Angular naming conventions since starting when Ionic wasn't offering any best practices with the assumption that something built off of a framework would inherit best practices (I'm new to using opensource, my bad there).
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |